[5.3] Move code to log model in new scheduler history view#44587
Merged
rdeutz merged 7 commits intojoomla:5.3-devfrom Jan 7, 2025
Merged
[5.3] Move code to log model in new scheduler history view#44587rdeutz merged 7 commits intojoomla:5.3-devfrom
rdeutz merged 7 commits intojoomla:5.3-devfrom
Conversation
laoneo
changed the title
Kostelano
reviewed
Dec 6, 2024
administrator/components/com_scheduler/src/Controller/LogsController.php
Show resolved
Hide resolved
Contributor
|
just applied the pr and runned a default task
|
Member
Author
|
Please check the response of the ajax request in the browser console. What for an error did you get? |
Contributor
|
|
Member
Author
|
Set your server into debug mode and post the whole stack trace please. |
Contributor
|
my fault there was an obsolete plugin listening |
Contributor
|
I have tested this item ✅ successfully on 7bbfc2a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44587. |
wilsonge
approved these changes
Dec 7, 2024
4 tasks
HLeithner
added
b/c break
|
I have tested this item ✅ successfully on f9bfbdf Thanks laoneo. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44587. |
Member
Author
|
As I added only types, removed an obsolete string and alpha ordered the new strings, I mark this as RTC because it needs to go into an alpha. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44587. |
Member
Author
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44587. |
Contributor
|
Thanks. |
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jan 10, 2025
4 tasks
bembelimen
pushed a commit
that referenced
this pull request
Jan 10, 2025
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Apr 14, 2025
joomla/joomla-cms#41496 - (upmerge с 5.2х) joomla/joomla-cms#42530 + joomla/joomla-cms#43994 - (upmerge с 5.2х) joomla/joomla-cms#44009 - (upmerge с 5.2х) joomla/joomla-cms#44010 - (upmerge с 5.2х) joomla/joomla-cms#44161 + joomla/joomla-cms#44187 - (upmerge с 5.2х) joomla/joomla-cms#44207 - (upmerge с 5.2х) joomla/joomla-cms#44271 + joomla/joomla-cms#44273 + joomla/joomla-cms#44288 - (только для en-GB) joomla/joomla-cms#44348 - (upmerge с 5.2х) joomla/joomla-cms#44366 + joomla/joomla-cms#44367 - (upmerge с 5.2х) joomla/joomla-cms#44434 - (upmerge с 5.2х) joomla/joomla-cms#44448 - (upmerge с 5.2х) joomla/joomla-cms#44462 + joomla/joomla-cms#44487 - (upmerge с 5.2х) joomla/joomla-cms#44587 + joomla/joomla-cms#44600 + joomla/joomla-cms#44604 + joomla/joomla-cms#44621 - (upmerge с 5.2х) joomla/joomla-cms#44623 + joomla/joomla-cms#44632 + joomla/joomla-cms#44640 - (позже был REVERT joomla/joomla-cms#44845) joomla/joomla-cms#44714 - (upmerge с 5.2х) joomla/joomla-cms#44756 + joomla/joomla-cms#44768 - (upmerge с 5.2х) joomla/joomla-cms#44792 - (только для en-GB) joomla/joomla-cms#44813 + joomla/joomla-cms#44822 - (upmerge с 5.2х) joomla/joomla-cms#44839 + joomla/joomla-cms#44871 + joomla/joomla-cms#44954 + joomla/joomla-cms#45034 - (upmerge с 5.2х) joomla/joomla-cms#45058 - (только для en-GB) joomla/joomla-cms#45064 + joomla/joomla-cms#45078 - (только для en-GB) joomla/joomla-cms#45130 - (upmerge с 5.2х) joomla/joomla-cms#45240 - (upmerge с 5.2х) joomla/joomla-cms#45246 - (только для др. пакетов)
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This is a followup for #42530 which uses the existing functions of the MVC API and removes some duplicated code. Like that are all ACL checks done, the default events triggered and code looks more inline with the rest of the core.
Testing Instructions
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed